Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

highlight reserved words #1885

Merged
merged 5 commits into from
May 7, 2019
Merged

highlight reserved words #1885

merged 5 commits into from
May 7, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented May 3, 2019

fixes #1820

@ghost ghost assigned ayrat555 May 3, 2019
@ghost ghost added the in progress label May 3, 2019
@ayrat555 ayrat555 marked this pull request as ready for review May 3, 2019 14:20
@coveralls
Copy link

coveralls commented May 3, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 71ca9bcd-3f84-4f8d-9f45-1b56219582a1

  • 21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.05%) to 81.113%
Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/fetcher/token.ex 1 78.57%
apps/indexer/lib/indexer/fetcher/token_balance.ex 2 87.1%
apps/indexer/lib/indexer/block/fetcher.ex 3 86.57%
Totals Coverage Status
Change from base Build 827b324d-4e82-41b0-9d99-c08d80656d30: -0.05%
Covered Lines: 4621
Relevant Lines: 5697
💛 - Coveralls

@vbaranov
Copy link
Member

vbaranov commented May 6, 2019

@ayrat555 could you add a CHANGELOG entry?

@ayrat555
Copy link
Contributor Author

ayrat555 commented May 6, 2019

@vbaranov done

goodsoft
goodsoft reviewed May 6, 2019
View reviewed changes
apps/block_scout_web/lib/block_scout_web/views/address_decompiled_contract_view.ex
# red
"\e[94m" => "136, 0, 0"
"\e[94m" => ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I understand correctly that you almost completely disregard styles from decompiler now, except for gray color?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is gray anyway?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments

@ayrat555 ayrat555 merged commit 81956d2 into master May 7, 2019
@ghost ghost removed the in progress label May 7, 2019
@ayrat555 ayrat555 deleted the ab-highlight-reserved-words branch May 7, 2019 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodsoft goodsoft goodsoft approved these changes

@vbaranov vbaranov vbaranov approved these changes

@zachdaniel zachdaniel zachdaniel approved these changes

@saneery saneery saneery approved these changes

Assignees

@ayrat555 ayrat555

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve decompiled code highlighting
6 participants
@ayrat555 @coveralls @vbaranov @goodsoft @zachdaniel @saneery