Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore pong messages without error #1835

Merged
merged 1 commit into from
Apr 24, 2019
Merged

fix: ignore pong messages without error #1835

merged 1 commit into from
Apr 24, 2019

Conversation

zachdaniel
Copy link
Contributor

@zachdaniel zachdaniel commented Apr 24, 2019 •
edited
Loading

Pong messages are generating errors and killing the websocket connection.

Changelog

Bug Fixes

  • Handle the pong message correctly
  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@ghost ghost assigned zachdaniel Apr 24, 2019
@ghost ghost added the in progress label Apr 24, 2019
@vbaranov vbaranov requested review from vbaranov and goodsoft April 24, 2019 19:19
@coveralls
Copy link

coveralls commented Apr 24, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 3341699b-899c-4511-a892-3991159618fe

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 82.23%
Totals Coverage Status
Change from base Build 75a05e35-fde5-4564-8b92-4d3f29e96aaf: 0.04%
Covered Lines: 4447
Relevant Lines: 5408
💛 - Coveralls

@zachdaniel zachdaniel force-pushed the handle-pong-messages branch 2 times, most recently from cfcf256 to 23b57a9 Compare April 24, 2019 19:33
@zachdaniel zachdaniel force-pushed the handle-pong-messages branch from 23b57a9 to 8f7fcb8 Compare April 24, 2019 19:36
@vbaranov vbaranov merged commit a634f98 into master Apr 24, 2019
@ghost ghost removed the in progress label Apr 24, 2019
@vbaranov vbaranov deleted the handle-pong-messages branch April 24, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodsoft goodsoft goodsoft approved these changes

@vbaranov vbaranov vbaranov approved these changes

Assignees

@zachdaniel zachdaniel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zachdaniel @coveralls @goodsoft @vbaranov