Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add total blocks counter #1813

Merged
merged 4 commits into from
Apr 24, 2019
Merged

Add total blocks counter #1813

merged 4 commits into from
Apr 24, 2019

Conversation

saneery
Copy link
Contributor

@saneery saneery commented Apr 23, 2019 •
edited
Loading

@ghost ghost assigned saneery Apr 23, 2019
@ghost ghost added the in progress label Apr 23, 2019
@saneery saneery marked this pull request as ready for review April 23, 2019 11:28
@saneery saneery added the ready for review This PR is ready for reviews. label Apr 23, 2019
@coveralls
Copy link

coveralls commented Apr 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 08e44669-7732-42e0-a731-87b9e3134ae7

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 82.322%
Totals Coverage Status
Change from base Build 3508dc4e-3c09-4d31-a2d0-71137dd1bf3c: 0.02%
Covered Lines: 4452
Relevant Lines: 5408
💛 - Coveralls

vbaranov
vbaranov reviewed Apr 23, 2019
View reviewed changes
apps/block_scout_web/assets/js/pages/chain.js
@@ -46,11 +47,13 @@ function baseReducer (state = initialState, action) {
blocks: [
action.msg,
...state.blocks.slice(0, -1)
]
],
blockCount: action.msg.blockNumber + 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saneery does it handle the case when we have no blocks?

Copy link
Contributor Author

@saneery saneery Apr 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbaranov do you mean when no blocks in the database? This js code handles only when new block comes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vbaranov vbaranov self-requested a review April 24, 2019 12:39
@vbaranov vbaranov merged commit f3fdd4e into master Apr 24, 2019
@ghost ghost removed the in progress label Apr 24, 2019
@vbaranov vbaranov deleted the blocks_counter branch April 24, 2019 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodsoft goodsoft goodsoft approved these changes

@vbaranov vbaranov vbaranov approved these changes

@zachdaniel zachdaniel zachdaniel approved these changes

@ayrat555 ayrat555 Awaiting requested review from ayrat555

Assignees

@saneery saneery

Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saneery @coveralls @goodsoft @vbaranov @zachdaniel