Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix top nav autocomplete #1793

Merged
merged 6 commits into from
Apr 22, 2019
Merged

fix top nav autocomplete #1793

merged 6 commits into from
Apr 22, 2019

Conversation

ayrat555
Copy link
Contributor

fixes #1791

Changelog

  • fix top nav autocomplete

@ghost ghost assigned ayrat555 Apr 19, 2019
@ghost ghost added the in progress label Apr 19, 2019
@coveralls
Copy link

coveralls commented Apr 19, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 85263df5-c1d6-45f5-86b8-df2c0e0842b2

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 82.86%
Files with Coverage Reduction New Missed Lines %
apps/explorer/lib/explorer/chain/transaction_count_cache.ex 2 84.21%
Totals Coverage Status
Change from base Build ade463ff-22e4-4ef6-958f-6910984f8f39: 0.1%
Covered Lines: 4433
Relevant Lines: 5350
💛 - Coveralls

vbaranov
vbaranov requested changes Apr 19, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2019-04-19 at 17 17 20

There is overlay instead of a break now

@ghost ghost assigned vbaranov Apr 22, 2019
@vbaranov vbaranov self-requested a review April 22, 2019 09:45
@vbaranov
Copy link
Member

There is overlay instead of a break now

Fixed

@vbaranov vbaranov merged commit 72b07bf into master Apr 22, 2019
@ghost ghost removed the in progress label Apr 22, 2019
@vbaranov vbaranov deleted the ab-fix-top-nav-autocomplete branch April 22, 2019 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@saneery saneery saneery approved these changes

@zachdaniel zachdaniel Awaiting requested review from zachdaniel

@goodsoft goodsoft Awaiting requested review from goodsoft

Assignees

@vbaranov vbaranov

@ayrat555 ayrat555

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visual issues with the full-text search
4 participants
@ayrat555 @coveralls @vbaranov @saneery