Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Chore) Change twitter acc link to official Blockscout acc twitter #1757

Merged
merged 5 commits into from
Apr 18, 2019
Merged

(Chore) Change twitter acc link to official Blockscout acc twitter #1757

merged 5 commits into from
Apr 18, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Apr 15, 2019 •
edited
Loading

Relates to #1772

Motivation

Official Blockscout twitter account has been created: https://twitter.com/_blockscout

Changelog

  • Twitter link in the footer has been changed to Official Blockscout twitter account

    • I added an entry to CHANGELOG.md with this PR
    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
    • I checked whether I should update the docs and did so if necessary

@ghost ghost assigned vbaranov Apr 15, 2019
@ghost ghost added the in progress label Apr 15, 2019
@coveralls
Copy link

coveralls commented Apr 15, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 5d346d85-2d1e-4f4d-8931-50406b1f6479

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 83.12%
Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/block/catchup/fetcher.ex 4 68.0%
Totals Coverage Status
Change from base Build 260a266a-bb07-4ba1-a257-938bce28b618: 0.04%
Covered Lines: 4422
Relevant Lines: 5320
💛 - Coveralls

@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Apr 16, 2019
@vbaranov vbaranov merged commit 35e4df1 into master Apr 18, 2019
@ghost ghost removed the in progress label Apr 18, 2019
@vbaranov vbaranov deleted the change-twitter-acc branch April 18, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodsoft goodsoft goodsoft approved these changes

@saneery saneery saneery approved these changes

@zachdaniel zachdaniel Awaiting requested review from zachdaniel

@ayrat555 ayrat555 Awaiting requested review from ayrat555

Assignees

@vbaranov vbaranov

Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vbaranov @coveralls @goodsoft @saneery