Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify contracts rpc #1665

Merged
merged 1 commit into from
Apr 3, 2019
Merged

Verify contracts rpc #1665

merged 1 commit into from
Apr 3, 2019

Conversation

zachdaniel
Copy link
Contributor

Resolves #1564

Motivation

  • We want to support verification of smart contracts via the API, so that the process can be automated.

Changelog

Enhancements

  • Adds endpoint to verify smart contracts via the API.

This also includes the changes in #1658. We should either wait until that one is merged, or close that one and merge this one to get both.

@ghost ghost assigned zachdaniel Mar 27, 2019
@ghost ghost added the in progress label Mar 27, 2019
@zachdaniel zachdaniel force-pushed the verify-contracts-rpc branch from daf6c03 to 2590b49 Compare March 27, 2019 22:26
@coveralls
Copy link

coveralls commented Mar 27, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build cae9baa0-ece2-403f-8ccf-8d6710d97d2c

  • 15 of 21 (71.43%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 83.066%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/controllers/api/rpc/contract_controller.ex 14 20 70.0%
Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/internal_transaction/fetcher.ex 2 58.62%
apps/ethereum_jsonrpc/test/support/ethereum_jsonrpc/web_socket/case/mox.ex 5 66.67%
Totals Coverage Status
Change from base Build 66c7837c-f260-432f-a1f8-2fa6b9271d3b: -0.2%
Covered Lines: 4449
Relevant Lines: 5356
💛 - Coveralls

@zachdaniel zachdaniel force-pushed the verify-contracts-rpc branch 5 times, most recently from 59fb7a5 to aa76d62 Compare April 2, 2019 18:10
goodsoft
goodsoft approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@goodsoft goodsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with apps/block_scout_web directory enough to thoroughly review this, but I don't see anything criminal.

@zachdaniel zachdaniel force-pushed the verify-contracts-rpc branch 3 times, most recently from 7b098f0 to 105751d Compare April 3, 2019 14:19
@zachdaniel zachdaniel force-pushed the verify-contracts-rpc branch from 105751d to 1f05f67 Compare April 3, 2019 15:04
@zachdaniel zachdaniel merged commit c634172 into master Apr 3, 2019
@ghost ghost removed the in progress label Apr 3, 2019
@zachdaniel zachdaniel deleted the verify-contracts-rpc branch April 4, 2019 20:28
@ayrat555 ayrat555 mentioned this pull request Apr 8, 2019
Merged
@berndbohmeier berndbohmeier mentioned this pull request Jun 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodsoft goodsoft goodsoft approved these changes

@ayrat555 ayrat555 ayrat555 approved these changes

Assignees

@zachdaniel zachdaniel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify smart contract through an API endpoint
4 participants
@zachdaniel @coveralls @goodsoft @ayrat555