Reduce block_rewards in the catchup fetcher #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Pull Request Test Coverage Report for Build 132878e0-0b69-4917-8619-a2f584074bf7
💛 - Coveralls |
goodsoft
force-pushed
the
gs-reduce-uncle-rewards
branch
2 times, most recently
from
c0108c7 to
7bd3e13
Compare
When a block contains rewards for two uncle blocks to the same address, the Cardinality Violation error occurs due to rewards not being reduced.
Fixes #1584 If one address is rewarded for two different uncles in one block, cardinality violation occured due to rewards not being reduced. The reducing function from Block.Rewards.Fetcher is now reused in Block.Fetcher.
goodsoft
force-pushed
the
gs-reduce-uncle-rewards
branch
from
7bd3e13 to
5ed8a95
Compare
ayrat555
approved these changes
Mar 19, 2019
vbaranov
approved these changes
Mar 19, 2019
zachdaniel
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1584
If one address was rewarded for two different uncles in one block, cardinality violation occurred due to rewards not being properly reduced.
The reducing function from
Block.Rewards.Fetcheris now reused inBlock.Fetcher.