Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Fix) Exact timestamp display #1586

Merged
merged 1 commit into from
Mar 18, 2019
Merged

(Fix) Exact timestamp display #1586

merged 1 commit into from
Mar 18, 2019

Conversation

vbaranov
Copy link
Member

Relates #1551

Motivation

  1. We shouldn't display an exact time in a tile (the original issue [Suggestion] Exact Date and Time #1506 was only about the display of exact time in transaction details block):
    Screenshot 2019-03-18 at 12 06 55
  2. Exact time doesn't display in transaction details block if the path doesn't start with /tx. For example, for Blockscocut instances tx details path begins with /${preifx}/${chain}/tx

Changelog

  • in-tile attribute has been added for elements inside tiles to exclude exact time display from them
  • tx details page path search mask has been fixed.

Bug Fixes

  • Exclude exact timestamp from tiles
  • fix tx details page path search mask for displaying of exact time

@ghost ghost assigned vbaranov Mar 18, 2019
@ghost ghost added the in progress label Mar 18, 2019
@vbaranov vbaranov added ready for review This PR is ready for reviews. and removed in progress labels Mar 18, 2019
@vbaranov vbaranov merged commit d86cea2 into master Mar 18, 2019
@vbaranov vbaranov deleted the exact-timestamp-fix branch March 18, 2019 13:24
@berndbohmeier berndbohmeier mentioned this pull request Jun 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

@ayrat555 ayrat555 ayrat555 approved these changes

@goodsoft goodsoft Awaiting requested review from goodsoft

Assignees

@vbaranov vbaranov

Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vbaranov @zachdaniel @ayrat555