(Feature) Add the link to release in the footer #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Pull Request Test Coverage Report for Build e7151055-f3e6-4f2a-b035-55bb27fdea9d
💛 - Coveralls |
ayrat555
reviewed
Mar 12, 2019
| if release_link == "" || release_link == nil do | ||
| _version_link = version | ||
| else | ||
| _version_link = html_escape({:safe, "<a href=\"#{release_link}\" target=\"_blank\">#{version}</a>"}) |
There was a problem hiding this comment.
we can get rid of _version_link variable. the last expression will be returned anyway
There was a problem hiding this comment.
Thanks! var has been removed.
vbaranov
added
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1525
Motivation
Changelog
Enhancements
RELEASE_LINKhas been added. The link to release (if corresponding ENV variable is not empty) has been added to the version number in the footer. If no variable present, the version number is displayed without a link.