Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add index for created_contract_address_hash in transactions #1498

Merged
merged 2 commits into from
Feb 28, 2019
Merged

add index for created_contract_address_hash in transactions #1498

merged 2 commits into from
Feb 28, 2019

Conversation

ayrat555
Copy link
Contributor

Motivation

it is used when updating created_contract_code_indexed_at in addresses runner
https://github.com/poanetwork/blockscout/blob/master/apps/explorer/lib/explorer/chain/import/runner/addresses.ex#L143

Changelog

  • add index for created_contract_address_hash in transactions

@ghost ghost assigned ayrat555 Feb 28, 2019
@ghost ghost added the in progress label Feb 28, 2019
vbaranov
vbaranov reviewed Feb 28, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor remark: this is a typo in the name of the file: has instead of hash
Let's rename migration file from 20190228102650_add_index_created_contract_address_has.exs to 20190228102650_add_index_created_contract_address_hash.exs

@ayrat555
Rename 20190228102650_add_index_created_contract_address_has.exs to 2…
59e1b99 
…0190228102650_add_index_created_contract_address_hash.exs
@coveralls
Copy link

Pull Request Test Coverage Report for Build b539c425-a100-432c-9993-15d1c098611c

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.64%
Totals Coverage Status
Change from base Build 9fd3a554-733b-4ae2-9e07-c44fc41b9489: 0.0%
Covered Lines: 4254
Relevant Lines: 5026
💛 - Coveralls

@ayrat555 ayrat555 requested a review from vbaranov February 28, 2019 15:06
@ayrat555 ayrat555 merged commit 98b261e into master Feb 28, 2019
@ghost ghost removed the in progress label Feb 28, 2019
@vbaranov vbaranov deleted the ab-add-index-created-contract-hash branch May 28, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@zachdaniel zachdaniel zachdaniel approved these changes

Assignees

@ayrat555 ayrat555

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ayrat555 @coveralls @vbaranov @zachdaniel