Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not do work in process initialization #1493

Merged
merged 4 commits into from
Feb 28, 2019
Merged

do not do work in process initialization #1493

merged 4 commits into from
Feb 28, 2019

Conversation

ayrat555
Copy link
Contributor

Changelog

  • do not do work in process initialization

Bug Fixes

  • FailedCreatedAddress process was doing heavy work in its initialization. It's wrong because it was blocking other processes.

@ghost ghost assigned ayrat555 Feb 27, 2019
@ghost ghost added the in progress label Feb 27, 2019
@coveralls
Copy link

coveralls commented Feb 27, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build e29cc9ff-f1bc-4ce9-b201-cd464132a32a

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 84.606%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/indexer/lib/indexer/temporary/failed_created_addresses.ex 0 3 0.0%
Totals Coverage Status
Change from base Build 9801c001-bc95-43eb-8289-23074198dc83: -0.03%
Covered Lines: 4254
Relevant Lines: 5028
💛 - Coveralls

@ayrat555 ayrat555 requested a review from vbaranov February 28, 2019 15:07
@ayrat555 ayrat555 merged commit 3979325 into master Feb 28, 2019
@ghost ghost removed the in progress label Feb 28, 2019
@ayrat555 ayrat555 deleted the ab-fix-failed_created_addresses-process branch February 28, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@zachdaniel zachdaniel zachdaniel approved these changes

@acravenho acravenho acravenho approved these changes

Assignees

@ayrat555 ayrat555

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ayrat555 @coveralls @vbaranov @zachdaniel @acravenho