Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewind Counterpart #7

Open
Cananbolt opened this issue Dec 12, 2022 · 8 comments · May be fixed by #8
Open

Rewind Counterpart #7

Cananbolt opened this issue Dec 12, 2022 · 8 comments · May be fixed by #8

Comments

@Cananbolt
Copy link

This script is really unique, and really useful. I was wondering if it would be possible to have a rewind variant of this script?

@po5
Copy link
Owner

po5 commented Dec 12, 2022

Playing videos in reverse is a mess because codecs weren't designed for it, and mpv wasn't either.
https://mpv.io/manual/master/#options-play-dir

I've never played around with switching it at runtime, wonder how viable it is.

@Cananbolt
Copy link
Author

I understand, thanks for explaining it to me. Hopefully one day it becomes possible.

@po5
Copy link
Owner

po5 commented Dec 26, 2022

Setting it at runtime actually works decently well, at least on my setup. (It's buggy but not as bad as I expected)

@po5 po5 linked a pull request Dec 26, 2022 that will close this issue
20 tasks
@xfzv
Copy link

xfzv commented Dec 28, 2022

I'm playing around with the rewind feature. It works pretty well for me as well, very cool.

I was trying to use these keybindings (along with Natural-Harmonia-Gropius/InputEvent):

LEFT    seek -5                                  #@click
LEFT    script-binding evafast/evafast-rewind    #@press

but the second one wouldn't work. Then I realized that this does both (seek with a single press, rewind when pressed continuously):

LEFT    script-binding evafast/evafast-rewind

@po5
Copy link
Owner

po5 commented Dec 28, 2022

I do want to add a keybind for toggling rewind mode. soontm
And better documentation is on the roadmap (:

@xfzv
Copy link

xfzv commented Jan 2, 2023

@po5

I'm having an issue fter updating to 7de120b.

I'm using the following keybindings (with Natural-Harmonia-Gropius/InputEvent):

RIGHT    seek 5                                      #@click
RIGHT    script-binding evafast/speedup              #@press
RIGHT    script-binding evafast/slowdown             #@release

I'm using speed_cap=3.5. If I release RIGHT before speed reaches 3.5, then the speed returns to the original value as expected. However, if I keep RIGHT pressed until speed reaches 3.5, then, when releasing RIGHT, speed is stuck at 3.5.

Note that it doesn't occur with all files, at least for me.

I know this is still a WIP but I thought I would let you know.

@po5
Copy link
Owner

po5 commented Jan 5, 2023

@xfzv Should be fixed in 20ced3a.
You miss out on some QoL features by not using the hybrid keybind directly: Speed correction halting when changing its direction (e.g. pressing right while we are slowing down from the last press and slowdown isn't finished), speed resetting instantly on seek.

I could make speed resets on seek work, but will have to be careful to not interfere with other changes to the speed.

Is there any reason why you're reimplementing evafast's hybrid key through InputEvent?

@xfzv
Copy link

xfzv commented Jan 5, 2023

@xfzv Should be fixed in 20ced3a.

Can confirm it's fixed with 20ced3a, thank you.

You miss out on some QoL features by not using the hybrid keybind directly: Speed correction halting when changing its direction (e.g. pressing right while we are slowing down from the last press and slowdown isn't finished), speed resetting instantly on seek.

I could make speed resets on seek work, but will have to be careful to not interfere with other changes to the speed.

Is there any reason why you're reimplementing evafast's hybrid key through InputEvent?

You're right. I can't remember why I did this.. it makes no sense indeed. 🥸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants