Broken behavior: files containing dots in the name

[Goncaloo42]

Category

[ ] Enhancement

[ ] Bug

[x ] Question

Related issues? #1022

Version

Please specify what version of the library you are using: [3.9.0]

Expected / Desired Behavior / Question

I'm having an issue using the ListItemAttachments component from your library. Basically after adding and configuring the component on a form inside a SharePoint WebPart, pretty much everything works as expected. BUT one thing that does not behave as expected is when adding attachments that contain one or more dots (".") in the name, the file type icon is not displayed (ex. PDF, Word, etc.)

After researching, I found out that this issue was already addressed here

Can someone help me figure why is it still showing blank icons for me?

Thanks!

[ghost]

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

[github-actions]

Thank you for submitting your first issue to this project.

[NishkalankBezawada]

Hello @Goncaloo42,

I was able to resolve this issue. Will be creating a pull request.

Below are the attachments,

Thanks,
Nishkalank

[NishkalankBezawada]

Hello @Goncaloo42,

The solution is as below,

Solution

While loading the attachment preview at method loadAttachmentPreview we call GetFileImageUrl to fetch the previewImageUrl.

The old code is as below,

    const _fileTypes = _file.FileName.split('.');
    const _fileExtension = _fileTypes[1];

And since, the scenario when we have one or more dots (".") in the file name, the _fileExtension which will get the first element of array from _fileTypes

The corrected code is as below

const _fileExtension = _file.FileName.substr(_file.FileName.lastIndexOf('.') + 1);

this change will get the exact extension of the file.

below are the images from my local workbench.

Thanks,
Nishkalank Bezawada

[Goncaloo42]

Hello @NishkalankBezawada,
Thank you for your reply and your help!

Now I just need to wait for your changes to be live so I can update the reference in my solution, correct?

[NishkalankBezawada]

Hello @NishkalankBezawada,

Thank you for your reply and your help!

Now I just need to wait for your changes to be live so I can update the reference in my solution, correct?

Hej, Well that's true.

//Nishkalank

[joelfmrodrigues]

@Goncaloo42 many thanks for raising this issue, and many thanks @NishkalankBezawada for the PR.
I have just merged the PR and a new beta version of the package containing the fix should be automatically published in a few minutes.

[joelfmrodrigues]

New release just published, closing