Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label prop is missing on RichText #1375

Closed
michaelmaillot opened this issue Nov 30, 2022 · 4 comments · Fixed by #1471
Closed

label prop is missing on RichText #1375

michaelmaillot opened this issue Nov 30, 2022 · 4 comments · Fixed by #1471
Assignees
Labels
status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. type:enhancement New feature or enhancement of existing capability
Milestone

Comments

@michaelmaillot
Copy link
Collaborator

Category

[x] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [3.12.0]

Expected / Desired Behavior / Question

When using the RichText control, I'm expecting to be able to refer the component to a label (through an id) or mentioning a label text as a prop available

Observed Behavior

No label prop or an "id" attribute (which is available in the react-quill library used under the hood) that could be linked to a label.

Steps to Reproduce

  • create and SPFx app (WebPart, extension,...)
  • add the RichText control
  • try to add a label with reference to the control through an id, or try to add a label prop

Two approaches from my perspective:

  • drill up the "id" prop already available in the react-quill component
  • add a new prop "label" as it exists on Fluent UI controls like TextField, which accepts a string
@ghost
Copy link

ghost commented Nov 30, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Nov 30, 2022
@michaelmaillot
Copy link
Collaborator Author

I can give a try on this one if you don't mind 🙂

@joelfmrodrigues
Copy link
Collaborator

Hi @michaelmaillot , that would be great ☺️

@michaelmaillot
Copy link
Collaborator Author

Great, assign it to me please @joelfmrodrigues 🤗

@joelfmrodrigues joelfmrodrigues added status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. type:enhancement New feature or enhancement of existing capability and removed Needs: Triage 🔍 labels Jan 19, 2023
@AJIXuMuK AJIXuMuK added this to the 3.13.0 milestone Jan 30, 2023
@AJIXuMuK AJIXuMuK mentioned this issue Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants