Merge branch 'dev' into Issue2986

Author: gautamdsheth

CHANGELOG.md

@@ -21,6 +21,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 - Fixed issue with `Grant-PnPAzureADAppSitePermission` cmdlet where users are not able to set selected site in the `Sites.Selected` permission. [#2983](https://github.com/pnp/powershell/pull/2983)
 - Fixed issue with `Get-PnPList` cmdlet not working with site-relative URL as identity. [#3005](https://github.com/pnp/powershell/pull/3005)
 - Fixed issue with `Add-PnPNavigationNode` cmdlet where the target audience would not correctly be set when creating a node as a child of a parent node [#2940](https://github.com/pnp/powershell/pull/2940)
+- Fixed regressions within the following cmdlets `Get-PnPTenantCdnEnabled`, `Get-PnPTenantCdnOrigin`, `Get-PnPTenantCdnPolicies`, `Get-PnPTenantDeletedSite`, `Get-PnPTenantInstance` [#3030](https://github.com/pnp/powershell/pull/3030)
+- Fixed issue where `Add-PnPSiteCollectionAdmin -PrimarySiteCollectionAdmin <user>` would require owners to be specified as well. [#3035](https://github.com/pnp/powershell/pull/3035)
 
 ### Removed
 

README.md

@@ -8,16 +8,13 @@ Last version | Last nightly version
 
 This module is a successor of the [PnP-PowerShell](https://github.com/pnp/pnp-powershell) module. The original cmdlets only work on Windows and Windows PowerShell and supports SharePoint On-Premises (2013, 2016 and 2019) and SharePoint Online. This version of the cmdlets is cross-platform (i.e it works on Windows, MacOS and Linux) but it will only support SharePoint Online. Going forward we will only be **actively maintaining the cross-platform PnP PowerShell** module.
 
-For more information about installing or upgrading to this module, please refer to the documentation at https://pnp.github.io/powershell/articles/index.html
+For more information about installing or upgrading to this module, please refer to [the documentation](https://pnp.github.io/powershell/articles/index.html).
 
 ## IMPORTANT - New PnP PowerShell 2.x
 
-As the technologies behind PowerShell evolve, so will the PnP PowerShell module. 
-Since Microsoft is not supporting .NET 3.1 since December 2022, and .NET Framework not actively developed (and not cross platform), we are currently working on PnP PowerShell 2.x. 
+As the technologies behind PowerShell evolve, so will the PnP PowerShell module. Microsoft is no longer supporting .NET 3.1 since December 2022, and .NET Framework is not actively being developed anymore. It is also not cross platform. PnP PowerShell 2.x will therefore no longer support PowerShell 5.1 nor the ISE. 
 
-Therefore, **this new version going forward will not support PowerShell 5.1 nor the ISE**. 
-
-PnP PowerShell 2.x is already available should you wish to update now, and we have created a [guide](https://github.com/pnp/powershell/blob/dev/MIGRATE-1.0-to-2.0.md) for that purpose. If you are still using PowerShell 5.1 or the ISE, and want to use the latest major or nightly release, you will need to specify the required version like below: 
+We have created a [guide](https://github.com/pnp/powershell/blob/dev/MIGRATE-1.0-to-2.0.md) for upgrading from previous versions to PnP PowerShell 2.x. If you are still using PowerShell 5.1 or the ISE, and want to use the latest major or nightly release, you will need to specify the required version like below: 
 
 `Install-Module PnP.PowerShell -RequiredVersion 1.12.0 -Force`
 
@@ -32,9 +29,3 @@ This project has adopted the [Microsoft Open Source Code of Conduct](https://ope
 
 
 <img src="https://m365-visitor-stats.azurewebsites.net/pnp-powershell/readme" />
-
-
-## Updating from 1.x to 2.x
-
-Please refer to [this page](MIGRATE-1.0-to-2.0.md) while performing an update from your 1.x version to 2.x version of PnP PowerShell.
-

documentation/Add-PnPSiteCollectionAdmin.md

@@ -46,7 +46,7 @@ This will add all users with their title ending with "Doe" as additional seconda
 
 ### EXAMPLE 4
 ```powershell
-Add-PnPSiteCollectionAdmin -PrimarySiteCollectionAdminrs "user@contoso.onmicrosoft.com"
+Add-PnPSiteCollectionAdmin -PrimarySiteCollectionAdmin "user@contoso.onmicrosoft.com"
 ```
 
 This will set user@contoso.onmicrosoft.com as the primary site collection administrator of the site collection in the current context
@@ -74,7 +74,7 @@ Specifies owner(s) to add as site collection administrators. They will be added
 Type: System.Collections.Generic.List`1[PnP.PowerShell.Commands.Base.PipeBinds.UserPipeBind]
 Parameter Sets: (All)
 
-Required: True
+Required: False
 Position: Named
 Default value: None
 Accept pipeline input: True (ByValue)

documentation/Get-PnPAzureACSPrincipal.md

@@ -39,14 +39,14 @@ Returns the Azure ACS principals
 Get-PnPAzureACSPrincipal -IncludeSubsites
 ```
 
-Returns the lists of Azure ACS principals installed in your site collection as well as the subsites.
+Returns the lists of Azure ACS principals installed in your site collection as well as the subsites. The ValidUntil property will not be populated in this scenario.
 
 ### EXAMPLE 3
 ```powershell
 Get-PnPAzureACSPrincipal -Scope Tenant
 ```
 
-Returns the lists of Azure ACS principals installed in your Tenant.
+Returns the lists of Azure ACS principals installed in your Tenant. This a very heavy operation, so it might take some time before we get the results.
 
 ### EXAMPLE 4
 ```powershell
@@ -74,6 +74,7 @@ Accept wildcard characters: False
 ### -Scope
 When specified, it determines the scope of the Azure ACS principals. 
 Supported values are `List, Web, Site, Tenant , All`.
+Only with `Tenant` and `All` the `ValidUntil` property will be populated. For the other options it will not, this is by design and makes the cmdlet perform faster.
 
 ```yaml
 Type: Enum (AzureACSPrincipalScope)
@@ -101,5 +102,3 @@ Accept wildcard characters: False
 ## RELATED LINKS
 
 [Microsoft 365 Patterns and Practices](https://aka.ms/m365pnp)
-
-

documentation/Get-PnPUserProfileProperty.md

@@ -15,7 +15,7 @@ online version: https://pnp.github.io/powershell/cmdlets/Get-PnPUserProfilePrope
 
 * SharePoint: Access to the SharePoint Tenant Administration site
 
-You must connect to the tenant admin website (https://:<tenant>-admin.sharepoint.com) with Connect-PnPOnline in order to use this cmdlet. 
+You must connect to the tenant admin website (https://\<tenant\>-admin.sharepoint.com) with Connect-PnPOnline in order to use this cmdlet. 
 
 ## SYNTAX
 

documentation/Set-PnPUserProfileProperty.md

@@ -15,7 +15,7 @@ online version: https://pnp.github.io/powershell/cmdlets/Set-PnPUserProfilePrope
 
 * SharePoint: Access to the SharePoint Tenant Administration site
 
-Office365 only: Uses the tenant API to retrieve site information. You must connect to the tenant admin website (https://:<tenant>-admin.sharepoint.com) with Connect-PnPOnline in order to use this command.
+Office365 only: Uses the tenant API to retrieve site information. You must connect to the tenant admin website (https://\<tenant\>-admin.sharepoint.com) with Connect-PnPOnline in order to use this command.
 
 ## SYNTAX
 

pages/articles/vscodeextension.md

@@ -1,11 +1,11 @@
 # Visual Studio Code Extension
 
-If you like using Visual Studio Code for the development of your PnP PowerShell scripts, you might want to try the PnP PowerShell extension which is available for it. It provides various features to be helpful when creating scripts using PnP PowerShell.
+If you like using Visual Studio Code to develop your PnP PowerShell scripts, you might want to try the PnP PowerShell extension to boost your productivity. It provides various features that may be helpful when creating scripts using PnP PowerShell.
 
-Currently the extension provides:
+Currently, the extension provides the following:
 
-1. docs viewer inside VS Code
-1. samples gallery
-1. snippets with all possible commands
+1. full docs for every PnP PowerShell command directly in VS Code
+2. samples gallery with samples from [PnP script sample repo](https://pnp.github.io/script-samples/)
+3. snippets with all possible commands
 
-Check out the [PnP PowerShell Visual Studio Code Extension](https://marketplace.visualstudio.com/items?itemName=adamwojcikit.pnp-powershell-extension) page for more information and downloading it.
+Check out the [PnP PowerShell Visual Studio Code Extension](https://marketplace.visualstudio.com/items?itemName=adamwojcikit.pnp-powershell-extension) page for more information.

pnpframework_hash.txt

@@ -1 +1 @@
-7a2cad4934e9b943150158ddb04c4b61676d7268
+eed6662f07ce5191ecd8dd725404c5c4ddff43b1

pnppowershell_hash.txt

@@ -1 +1 @@
-82e7e513cc36b80fe010a6c5c8860f3a28e03ecf
+2a4f7eef794b28a9f518bf0bff6bf11474ad5827