Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move decomp.svd_approx to a dedicated module #194

Closed
pnkraemer opened this issue May 27, 2024 · 0 comments · Fixed by #198
Closed

Move decomp.svd_approx to a dedicated module #194

pnkraemer opened this issue May 27, 2024 · 0 comments · Fixed by #198
Labels
enhancement New feature or request

Comments

@pnkraemer
Copy link
Owner

Currently, svd_approx sits in matfree.decomp but there will likely be more eigenvalue-related functions at some point soon.

I propose moving svd_approx to a new module, e.g. matfree.eig, where it does not clutter the decomp namespace and can start attracting more eigenvalue codes.
@pnkraemer pnkraemer added the enhancement New feature or request label May 27, 2024
@pnkraemer pnkraemer linked a pull request May 28, 2024 that will close this issue
Remove matfree.pinv and implement matfree.eig #198
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove matfree.pinv and implement matfree.eig pnkraemer/matfree
1 participant
@pnkraemer