Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNG nonconformance: duplicate eXIf chunks. #634

Open
jbowler opened this issue Jan 3, 2025 · 1 comment
Open

PNG nonconformance: duplicate eXIf chunks. #634

jbowler opened this issue Jan 3, 2025 · 1 comment

Comments

@jbowler
Copy link
Contributor

jbowler commented Jan 3, 2025

I'm seeing files produced in November 2024 and later and apparently originally authored by PhotoShop 2024 and/or LightRoom which have the same eXIf chunk duplicated both before and after IDAT. This may have been fixed by the change in July 2023 which, so far as I can determine, prevents are write after IDAT if you occurred before and, anyway, I didn't think PhotoShop used libpng.

This issue is a placeholder in case anyone else sees it. libpng appears to be correct and it looks like the bug was fixed in July 2023

@jbowler
Copy link
Contributor Author

jbowler commented Jan 26, 2025

#645 provides the mechanism to reliably prevent this happening with "one only" chunks which may occur both before and after IDAT. eXIf was the only example (other chunks may occur multiple times).

#645 does not contain the write side of the solution but it will work on read; only the first eXIf will be accepted regardless of the app playing mix'n'match with png_info. Still a WiP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant