diff --git a/src/vanilla.ts b/src/vanilla.ts index 00a95616..f23edbf0 100644 --- a/src/vanilla.ts +++ b/src/vanilla.ts @@ -125,8 +125,8 @@ const buildProxyFunction = ( return } const value = Reflect.get(target, key) - const { enumerable = true } = - Reflect.getOwnPropertyDescriptor(target, key) ?? {} + const { enumerable = false } = + Reflect.getOwnPropertyDescriptor(target, key) as PropertyDescriptor const desc: PropertyDescriptor = { value, enumerable, diff --git a/tests/basic.test.tsx b/tests/basic.test.tsx index 509a75d1..eb1fa068 100644 --- a/tests/basic.test.tsx +++ b/tests/basic.test.tsx @@ -1,7 +1,7 @@ import { StrictMode, useEffect, useRef, useState } from 'react' import { fireEvent, render, waitFor } from '@testing-library/react' -import { proxy, useSnapshot, snapshot } from 'valtio' import { expect, it, vi } from 'vitest' +import { proxy, snapshot, useSnapshot } from 'valtio' it('simple counter', async () => { const obj = proxy({ count: 0 }) @@ -495,6 +495,6 @@ it('sync snapshot between nested components (#460)', async () => { }) it('respects property enumerability (#726)', async () => { - let x = proxy(Object.defineProperty({ a: 1 }, 'b', { value: 2 })) + const x = proxy(Object.defineProperty({ a: 1 }, 'b', { value: 2 })) expect(Object.keys(snapshot(x))).toEqual(Object.keys(x)) })