Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid OptimizedCineonToneMapping #655

Closed
nine-fox opened this issue Sep 9, 2024 · 2 comments
Closed

Invalid OptimizedCineonToneMapping #655

nine-fox opened this issue Sep 9, 2024 · 2 comments
Labels
bug Something isn't working compatibility A problem that affects compatibility with external libraries

Comments

@nine-fox
Copy link

nine-fox commented Sep 9, 2024

Hi,

I just found the following code is invalid in ToneMappingEffect.js:

this.defines.set("toneMapping(texel)", "OptimizedCineonToneMapping(texel)");

It will emit shader compile error under there.js r168

Change it to the following will remove the error:

this.defines.set("toneMapping(texel)", "CineonToneMapping(texel)");

I am using postprocessing 6.36.1

@vanruesc
Copy link
Member

vanruesc commented Sep 9, 2024

Oh, thanks for the report. That's a breaking change from three that went through unnoticed. I'll work on a fix.

@vanruesc vanruesc added bug Something isn't working compatibility A problem that affects compatibility with external libraries labels Sep 9, 2024
@vanruesc
Copy link
Member

Fixed in postprocessing@6.36.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compatibility A problem that affects compatibility with external libraries
Projects
None yet
Development

No branches or pull requests

2 participants