Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move crashdump decoding out of submit main handler #14

Open
dktapps opened this issue Dec 24, 2018 · 0 comments
Open

Move crashdump decoding out of submit main handler #14

dktapps opened this issue Dec 24, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@dktapps
Copy link
Member

dktapps commented Dec 24, 2018

Currently a deferred recovery is used to prevent bad crashdumps from crashing the server. However, this also allows undesired recovery from things that are actually bugs, such as a slice index out of bounds.

This should be solved by encapsulating crashdump decoding inside a dedicated function which can have a deferred recovery of its own.

@dktapps dktapps added the bug Something isn't working label Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant