Does the error overlay websocket need a ping heartbeat?

[drather19]

Related to facebook/create-react-app#8091 in the latest CRA.

The same idle timeout seems to affect the websocket used in this plugin, as well (makes sense since it's constructing the same kind of connection).

[pmmmwh]

Related to facebook/create-react-app#8091 in the latest CRA.

The same idle timeout seems to affect the websocket used in this plugin, as well (makes sense since it's constructing the same kind of connection).

I didn't notice this until you mentioned it. Pinging seems like a bad idea on first thought, will have to check how webpack-dev-server handles that.

[pmmmwh]

I didn't notice this until you mentioned it. Pinging seems like a bad idea on first thought, will have to check how webpack-dev-server handles that.

Did a bit of further research - I think it would be best to move this upstream (to WDS/CRA) because we are just consuming sockets created by these parties generically. The implementation of a heartbeat is heavily dependent on the actual socket being used and is difficult for the overlay to control: for example, if the server did not implement handling for the 'pong' message, even if I can ping it successfully I have no confidence in whether the connection is still valid (the server could close the connection without disconnecting).

[pmmmwh]

Resolved by webpack/webpack-dev-server#2404.