Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Move compiler specific code out of the compile_runner and to the compiler #120

Open
AndreCostaaa opened this issue Sep 26, 2024 · 0 comments · May be fixed by #121
Open

Refactor: Move compiler specific code out of the compile_runner and to the compiler #120

AndreCostaaa opened this issue Sep 26, 2024 · 0 comments · May be fixed by #121
Assignees
@AndreCostaaa
Labels
p1 Priority 1

Comments

@AndreCostaaa
Copy link
Contributor

Currently, the compiler runner adds the gcc/g++ arguments

This is specific to gcc/g++ and should be handler by the compiler and not the runner

plx/src/core/compiler/compile_runner.rs

Lines 29 to 35 in f84b6ad

match output_path.to_str() {
Some(path) => {
// TODO this should probably somewhere else like `compiler` because this is
// specific to gcc/g++
args.push(String::from("-fdiagnostics-color=always"));
args.push(String::from("-o"));
args.push(String::from(path));

This refactor is important so we can start other build tools like xmake, cmake and java for instance
@AndreCostaaa AndreCostaaa self-assigned this Sep 26, 2024
@AndreCostaaa AndreCostaaa linked a pull request Sep 26, 2024 that will close this issue
refactor: move compiler args from runner to compiler #121
Open
@AndreCostaaa AndreCostaaa added the p1 Priority 1 label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreCostaaa AndreCostaaa

Labels
p1 Priority 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move compiler args from runner to compiler plx-pdg/plx
1 participant
@AndreCostaaa