From 696649c8c0351b8d753aa05d35e598aafdfe9dd7 Mon Sep 17 00:00:00 2001 From: Bouwe Westerdijk Date: Tue, 13 Aug 2024 08:25:43 +0200 Subject: [PATCH] Add walrus as suggested --- plugwise/data.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/plugwise/data.py b/plugwise/data.py index 0f649f44a..eb1056034 100644 --- a/plugwise/data.py +++ b/plugwise/data.py @@ -79,10 +79,12 @@ def _detect_low_batteries(self) -> list[str]: for msg_id, notification in list(self._notifications.items()): mac_address: str | None = None message: str | None = notification.get("message") - if message is not None and all(x in message for x in matches): - mac_addresses = re.findall(mac_pattern, message) - if mac_addresses: - mac_address = mac_addresses[0] # re.findall() outputs a list + if ( + message is not None + and all(x in message for x in matches) + and (mac_addresses := re.findall(mac_pattern, message) + ): + mac_address = mac_addresses[0] # re.findall() outputs a list if mac_address is not None: self._notifications.pop(msg_id)