Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO]: Cleanup models.py #3

Open
2 tasks
CoMPaTech opened this issue Apr 19, 2023 · 0 comments
Open
2 tasks

[TODO]: Cleanup models.py #3

CoMPaTech opened this issue Apr 19, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@CoMPaTech
Copy link
Member

CoMPaTech commented Apr 19, 2023

Todo

Follow-up from #1 merge, as per @bouwew comments


custom_components/plugwise_usb/models.py

  • L28-31 This part is no longer needed after the split.

Also below all plugwise_api=STICK, lines can be removed.


  • L35-36 Rewrite to class PlugwiseEntityDescription(EntityDescription):

Or remove this class and rename below classes to SensorEntityDescription, etc.

Maybe even better, move all descriptions (back) into the relevant files, as done in Core Plugwise

@CoMPaTech CoMPaTech added the enhancement New feature or request label Apr 19, 2023
@CoMPaTech CoMPaTech mentioned this issue Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant