Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hidden unless does not work if condition is other question with LDAP Select 2.8.3 #1454

Closed
achekmez opened this issue Jul 23, 2019 · 2 comments · Fixed by #1457
Closed

hidden unless does not work if condition is other question with LDAP Select 2.8.3 #1454

achekmez opened this issue Jul 23, 2019 · 2 comments · Fixed by #1457
Assignees
Labels

Comments

@achekmez
Copy link

hidden unless does not work if condition is other question with LDAP Select with plugin version 2.8.3 glpi version 9.4.3

To Reproduce
Steps to reproduce the behavior:

  1. make question
    type = LDAP Select,
    filter = (& (samaccountname=) (& (displayName=) (&(objectCategory=person)(objectClass=user)(memberOf:1.2.840.113556.1.4.1941:= cn=DG MP All Staff, OU=SharedMailboxes,OU=Moscow, DC=mpmsk, DC=corp)(givenName=)(sn=))))
    Attribute = (LDAP) City
  2. make second question
    show field = hidden unless
    1st question = (in my case for ex) Moscow
  3. try the form

expecting when in 1st question choose Moscow 2nd question should appear - but it does not.

Screenshots
If applicable, add screenshots to help explain your problem.
image
image
image
image

Desktop (please complete the following information):

  • OS: Win10
  • Browser chrome

it workes in plugin version 2.5.2 glpi ver 9.2.2

btry added a commit to btry/formcreator that referenced this issue Jul 29, 2019
@btry
Copy link
Collaborator

btry commented Jul 29, 2019

Hi

Comparisons are unsupported for this type of questions. It is unexpected that someone used them.

Please test this fix and feedback. I believe this should be sufficient to make it work.

#1457

@btry btry self-assigned this Jul 29, 2019
btry added a commit that referenced this issue Jul 30, 2019
btry added a commit that referenced this issue Jul 30, 2019
@btry
Copy link
Collaborator

btry commented Jul 30, 2019

Patch successfully tested

@btry btry reopened this Jul 30, 2019
@btry btry added this to the 2.8.4 milestone Jul 30, 2019
@btry btry removed this from the 2.8.4 milestone Aug 22, 2019
@btry btry closed this as completed in 1cb94ad Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants