fix(targetticket,targetchange): handle import failure on missing ques…

…tion Signed-off-by: Thierry Bugier <tbugier@teclib.com>
pluginsGLPI · Oct 16, 2020 · e17c5a3 · e17c5a3
1 parent 9ef1d73
commit e17c5a3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/inc/targetchange.class.php b/inc/targetchange.class.php
@@ -216,6 +216,10 @@ public static function import(PluginFormcreatorLinker $linker, $input = [], $con
          }
          /**@var PluginFormcreatorQuestion $question */
          $question = $linker->getObject($input[$fieldSetting['field']], PluginFormcreatorQuestion::class);
+         if ($question === false) {
+            $typeName = strtolower(self::getTypeName());
+            throw new ImportFailureException(sprintf(__('failed to add or update the %1$s %2$s: a question is missing and is used in a parameter of the target', 'formceator'), $typeName, $input['name']));
+         }
          $input[$fieldSetting['field']] = $question->getID();
       }
 

diff --git a/inc/targetticket.class.php b/inc/targetticket.class.php
@@ -1107,6 +1107,10 @@ public static function import(PluginFormcreatorLinker $linker, $input = [], $con
          }
          /**@var PluginFormcreatorQuestion $question */
          $question = $linker->getObject($input[$fieldSetting['field']], PluginFormcreatorQuestion::class);
+         if ($question === false) {
+            $typeName = strtolower(self::getTypeName());
+            throw new ImportFailureException(sprintf(__('failed to add or update the %1$s %2$s: a question is missing and is used in a parameter of the target', 'formceator'), $typeName, $input['name']));
+         }
          $input[$fieldSetting['field']] = $question->getID();
       }