fix: fatal error when not filling a date

Signed-off-by: Thierry Bugier <tbugier@teclib.com>
pluginsGLPI · Feb 16, 2021 · 940bfee · 940bfee
1 parent d47099a
commit 940bfee
Show file tree

Hide file tree

Showing 20 changed files with 20 additions and 20 deletions.
diff --git a/inc/field/actorfield.class.php b/inc/field/actorfield.class.php
@@ -213,7 +213,7 @@ public function getValueForDesign(): string {
       return implode("\r\n", $value);
    }
 
-   public function getValueForTargetText($richText): string {
+   public function getValueForTargetText($richText): ?string {
       $value = [];
       foreach ($this->value as $item) {
          if (filter_var($item, FILTER_VALIDATE_EMAIL) !== false) {

diff --git a/inc/field/checkboxesfield.class.php b/inc/field/checkboxesfield.class.php
@@ -276,7 +276,7 @@ public function hasInput($input): bool {
       return isset($input['formcreator_field_' . $this->question->getID()]);
    }
 
-   public function getValueForTargetText($richText): string {
+   public function getValueForTargetText($richText): ?string {
       $value = [];
       $values = $this->getAvailableValues();
 

diff --git a/inc/field/datefield.class.php b/inc/field/datefield.class.php
@@ -116,7 +116,7 @@ public function getValueForDesign(): string {
       return $this->value;
    }
 
-   public function getValueForTargetText($richText): string {
+   public function getValueForTargetText($richText): ?string {
       return Html::convDate($this->value);
    }
 

diff --git a/inc/field/datetimefield.class.php b/inc/field/datetimefield.class.php
@@ -122,7 +122,7 @@ public function hasInput($input): bool {
       return isset($input['formcreator_field_' . $this->question->getID()]);
    }
 
-   public function getValueForTargetText($richText): string {
+   public function getValueForTargetText($richText): ?string {
       return Html::convDateTime($this->value);
    }
 

diff --git a/inc/field/descriptionfield.class.php b/inc/field/descriptionfield.class.php
@@ -71,7 +71,7 @@ public function getValueForDesign(): string {
       return '';
    }
 
-   public function getValueForTargetText($richText): string {
+   public function getValueForTargetText($richText): ?string {
       $text = $this->question->fields['description'];
       if (!$richText) {
          $text = nl2br(strip_tags(html_entity_decode($text)));

diff --git a/inc/field/dropdownfield.class.php b/inc/field/dropdownfield.class.php
@@ -412,7 +412,7 @@ public function getValueForDesign(): string {
       return $this->value;
    }
 
-   public function getValueForTargetText($richText): string {
+   public function getValueForTargetText($richText): ?string {
       $DbUtil = new DbUtils();
       $itemtype = $this->getSubItemtype();
       if ($itemtype == User::class) {

diff --git a/inc/field/filefield.class.php b/inc/field/filefield.class.php
@@ -101,7 +101,7 @@ public function getValueForDesign(): string {
       return '';
    }
 
-   public function getValueForTargetText($richText): string {
+   public function getValueForTargetText($richText): ?string {
       return $this->value;
    }
 

diff --git a/inc/field/floatfield.class.php b/inc/field/floatfield.class.php
@@ -125,7 +125,7 @@ public function getValueForDesign(): string {
       return $this->value;
    }
 
-   public function getValueForTargetText($richText): string {
+   public function getValueForTargetText($richText): ?string {
       return $this->value;
    }
 

diff --git a/inc/field/hiddenfield.class.php b/inc/field/hiddenfield.class.php
@@ -110,7 +110,7 @@ public static function getName(): string {
       return _n('Hidden field', 'Hidden fields', 1);
    }
 
-   public function getValueForTargetText($richText): string {
+   public function getValueForTargetText($richText): ?string {
       return str_replace("\n", '\r\n', $this->value);
    }
 

diff --git a/inc/field/hostnamefield.class.php b/inc/field/hostnamefield.class.php
@@ -87,7 +87,7 @@ public function getValueForDesign(): string {
       return '';
    }
 
-   public function getValueForTargetText($richText): string {
+   public function getValueForTargetText($richText): ?string {
       return $this->value;
    }
 

diff --git a/inc/field/ipfield.class.php b/inc/field/ipfield.class.php
@@ -95,7 +95,7 @@ public function getValueForDesign(): string {
       return $this->value;
    }
 
-   public function getValueForTargetText($richText): string {
+   public function getValueForTargetText($richText): ?string {
       return $this->value;
    }
 

diff --git a/inc/field/radiosfield.class.php b/inc/field/radiosfield.class.php
@@ -216,7 +216,7 @@ public function getValueForDesign(): string {
       return $this->value;
    }
 
-   public function getValueForTargetText($richText): string {
+   public function getValueForTargetText($richText): ?string {
       return $this->value;
    }
 

diff --git a/inc/field/requesttypefield.class.php b/inc/field/requesttypefield.class.php
@@ -170,7 +170,7 @@ public function hasInput($input): bool {
       return isset($input['formcreator_field_' . $this->question->getID()]);
    }
 
-   public function getValueForTargetText($richText): string {
+   public function getValueForTargetText($richText): ?string {
       $available = $this->getAvailableValues();
       return $available[$this->value];
    }

diff --git a/inc/field/tagfield.class.php b/inc/field/tagfield.class.php
@@ -145,7 +145,7 @@ public function getValueForDesign(): string {
       return implode("\r\n", $this->value);
    }
 
-   public function getValueForTargetText($richText): string {
+   public function getValueForTargetText($richText): ?string {
       $value = Dropdown::getDropdownName(PluginTagTag::getTable(), $this->value);
       return $value;
    }

diff --git a/inc/field/textareafield.class.php b/inc/field/textareafield.class.php
@@ -214,7 +214,7 @@ public function parseAnswerValues($input, $nonDestructive = false): bool {
       return true;
    }
 
-   public function getValueForTargetText($richText): string {
+   public function getValueForTargetText($richText): ?string {
       $value = $this->value;
       if (!$richText) {
          $value = Toolbox::unclean_cross_side_scripting_deep($value);

diff --git a/inc/field/textfield.class.php b/inc/field/textfield.class.php
@@ -130,7 +130,7 @@ public function getValueForDesign(): string {
       return $this->value;
    }
 
-   public function getValueForTargetText($richText): string {
+   public function getValueForTargetText($richText): ?string {
       return $this->value;
    }
 

diff --git a/inc/field/timefield.class.php b/inc/field/timefield.class.php
@@ -117,7 +117,7 @@ public function getValueForDesign(): string {
       return $this->value;
    }
 
-   public function getValueForTargetText($richText): string {
+   public function getValueForTargetText($richText): ?string {
       $date = DateTime::createFromFormat("H:i:s", $this->value);
       if ($date === false) {
          return ' ';

diff --git a/inc/field/urgencyfield.class.php b/inc/field/urgencyfield.class.php
@@ -174,7 +174,7 @@ public function getValueForDesign(): string {
       return $this->value;
    }
 
-   public function getValueForTargetText($richText): string {
+   public function getValueForTargetText($richText): ?string {
       $available = $this->getAvailableValues();
       return $available[$this->value];
    }

diff --git a/inc/fieldinterface.class.php b/inc/fieldinterface.class.php
@@ -116,7 +116,7 @@ public function getValueForDesign() : string;
     *
     * @return string
     */
-   public function getValueForTargetText($richText) : string;
+   public function getValueForTargetText($richText): ?string;
 
    /**
     * Move uploaded files and make Document items

diff --git a/tests/fixture/PluginFormcreatorDependentField.php b/tests/fixture/PluginFormcreatorDependentField.php
@@ -161,7 +161,7 @@ public function getValueForDesign(): string {
       return $this->value;
    }
 
-   public function getValueForTargetText($richText): string {
+   public function getValueForTargetText($richText): ?string {
       return Toolbox::addslashes_deep($this->value);
    }