fix(formanswer): use of undefined variables

some link fixes
pluginsGLPI · Sep 9, 2019 · 363366f · 363366f
1 parent f05f2de
commit 363366f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/inc/form.class.php b/inc/form.class.php
@@ -1137,7 +1137,7 @@ protected function showMyLastForms() {
     * @return Null                     Nothing, just display the form
     */
    public function displayUserForm() {
-      global $CFG_GLPI, $DB;
+      global $CFG_GLPI;
 
       if (isset($_SESSION['formcreator']['data'])) {
          $data = $_SESSION['formcreator']['data'];

diff --git a/inc/formanswer.class.php b/inc/formanswer.class.php
@@ -1246,7 +1246,7 @@ private function createIssue() {
             $itemTicket->getFromDB($result['id']);
             $ticket = new Ticket();
             if (!$ticket->getFromDB($itemTicket->fields['tickets_id'])) {
-               throw new RuntimeException('Formcreator: Missing ticket ' . $itemTicket->fields['tickets_id'] . ' for formanswer ' . $formanswers_id);
+               throw new RuntimeException('Formcreator: Missing ticket ' . $itemTicket->fields['tickets_id'] . ' for formanswer ' . $this->getID());
             }
             $ticketId = $ticket->getID();
             $issue->add([
@@ -1306,7 +1306,7 @@ private function updateIssue() {
             $itemTicket->getFromDB($result['id']);
             $ticket = new Ticket();
             if (!$ticket->getFromDB($itemTicket->fields['tickets_id'])) {
-               throw new RuntimeException('Formcreator: Missing ticket ' . $itemTicket->fields['tickets_id'] . ' for formanswer ' . $formanswers_id);
+               throw new RuntimeException('Formcreator: Missing ticket ' . $itemTicket->fields['tickets_id'] . ' for formanswer ' . $this->getID());
             }
             $ticketId = $ticket->getID();
             $issue->getFromDBByCrit([

diff --git a/tests/suite-unit/PluginFormcreatorFormAnswer.php b/tests/suite-unit/PluginFormcreatorFormAnswer.php
@@ -52,7 +52,7 @@ public function testGetFullForm() {
       ]);
 
       $instance = $this->newTestedInstance();
-      $formAnswerId = $instance->add([
+      $instance->add([
          \PluginFormcreatorForm::getForeignKeyField() => $form->getID(),
          'formcreator_field_' . $question->getID() => ''
       ]);