fix(question): update of parameters broken

Signed-off-by: Thierry Bugier <tbugier@teclib.com>
pluginsGLPI · Jan 27, 2020 · 1418859 · 1418859
1 parent 9b7a692
commit 1418859
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/inc/question.class.php b/inc/question.class.php
@@ -611,7 +611,7 @@ public function setRequired($isRequired) {
     * @param array $input parameters
     */
    public function updateParameters($input) {
-      if (!isset($this->fields['fieldtype'])) {
+      if (!isset($input['fieldtype'])) {
          return;
       }
 

diff --git a/tests/src/CommonTestCase.php b/tests/src/CommonTestCase.php
@@ -235,7 +235,6 @@ protected function getQuestion($input = [], $sectionInput = [], $formInput = [])
       $question = new \PluginFormcreatorQuestion();
       $question->add($input);
       $question->getFromDB($question->getID());
-      $question->updateParameters($input);
 
       return $question;
    }