fix(install): prevent output in ajax response

pluginsGLPI · Jul 18, 2022 · 1d19d7c · 1d19d7c
1 parent f5369f6
commit 1d19d7c
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/install/install.php b/install/install.php
@@ -144,10 +144,9 @@ public function upgrade(Migration $migration, $args = []): bool {
          if ($oldVersion !== null) {
             $checkResult = true;
             if (version_compare($oldVersion, '2.13.0') >= 0) {
-               // more strict DB check : dynamic rows, utf8mb4, unsigned int for foreign keys
                $checkResult = $this->checkSchema(
                   $oldVersion,
-                  true,
+                  false,
                   false,
                   false,
                   false,
@@ -197,12 +196,13 @@ public function upgrade(Migration $migration, $args = []): bool {
          return false;
       }
 
+      ob_start();
       while ($fromSchemaVersion && isset($this->upgradeSteps[$fromSchemaVersion])) {
          $this->upgradeOneStep($this->upgradeSteps[$fromSchemaVersion]);
          $fromSchemaVersion = $this->upgradeSteps[$fromSchemaVersion];
       }
-
       $this->migration->executeMigration();
+
       // if the schema contains new tables
       $this->installSchema();
       $this->configureExistingEntities();
@@ -211,6 +211,7 @@ public function upgrade(Migration $migration, $args = []): bool {
       $this->createCronTasks();
       $this->createMiniDashboard();
       Config::setConfigurationValues('formcreator', ['schema_version' => PLUGIN_FORMCREATOR_SCHEMA_VERSION]);
+      ob_get_flush();
 
       if ($this->resyncIssues) {
          // An upgrade step requires a resync of the issues