Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of this project? #95

Closed
tarekrached opened this issue Feb 11, 2020 · 8 comments
Closed

Status of this project? #95

tarekrached opened this issue Feb 11, 2020 · 8 comments

Comments

@tarekrached
Copy link
Contributor

Hey Plotly folks! This is an amazing project, thank you so much for releasing it!

I'm curious about your plans for this repo - as of today, February 10, it's been 8 months since the last commit (c9b6ab6 Create FUNDING.yml) and over 15 months since the last substantive commit (e708ab4 on Nov 3, 2018).

In its current state, react-pivottable generates componentWillMount and componentWillUpdate warnings when used with current (16.x) React, and will probably not work with React 17.x when that drops.

There are three open dependabot PRs that are 4 months old at this point, which makes me wonder if the project owner is looking at the project.

I guess what I'm asking is: is this project abandoned? What can we do to support it? If I invest time in PRs to address the React warnings, are there folks at Plotly who will review them?

Thanks again - I do not take any of the work in this repo for granted, and really do appreciate what you have built. I would love to see it flourish.

@qweluke
Copy link

qweluke commented Feb 11, 2020

bump, I am also interested

@aboulang
Copy link

Same thought I have as I was deciding on using this vs the one used in Perspective (https://perspective.finos.org/). Also, it looks like pivottable.js that it is based on has enhancements that have not been updated in this package.

@nicolaskruchten
Copy link
Contributor

This project generally works great as-is and no one is really reporting bugs on it. The dependabot PRs didn't seem too urgent so I haven't looked at them. So the answer is... it's not dead, just doesn't seem like much work is needed.

If people want to propose changes and after discussion make some easy to review PRs, I'm happy to review them, merge them and release to NPM etc.

@tarekrached
Copy link
Contributor Author

Right on, that sounds great - I totally agree that it's works great as-is, with the exception of the the deprecated componentWillMount and componentWillUpdate warnings. I'll try and make a PR in the next few weeks for that. Again, we really appreciate you putting this out into the world!

@nicolaskruchten
Copy link
Contributor

Great!

With respect to the older-sibling project https://github.com/nicolaskruchten/pivottable I think the biggest thing missing is localization in this React version, and possible a few other odds and ends but I can't recall just now.

@aboulang aboulang mentioned this issue Feb 19, 2020
@nicolaskruchten
Copy link
Contributor

it looks like pivottable.js that it is based on has enhancements that have not been updated in this package

Just to be clear here: almost no development has happened in PivotTable.js since react-pivottable was released (both are quite mature now) so it's not the case that new stuff was added in one and not the other. Most likely I just didn't correctly port certain features when I built out react-pivottable :)

@aboulang
Copy link

Nicholas,

Nicolas,

Not an issue with new stuff, but was the PivotTable.js community providing bug fixes to PivotTable.js after react-pivottable was released? I assume that if both still have active communities, there could be some bug fixes that you would have had to apply to both?

@nicolaskruchten
Copy link
Contributor

Definitely still active, just merged @tarekrached's PR and released 0.10.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants