promiseError disappeared?

[alexcjohnson]

We still call lib.promiseError in lib.syncOrAsync but it has disappeared? What do we want to have happen here?

[rreusser]

Is this similar to fail_test.js?

https://github.com/plotly/plotly.js/blob/master/test/jasmine/assets/fail_test.js

[etpinard]

From 7fa9243#diff-e64ef427412e9bab4929b8b93ca12d96

[jklimke]

Hi, this came to my notice as i am receiving constantly warnings when using plotly in an promise based environment. As the promiseError function does not exist anymore, it should not be passed to promises for error handling as this causes a warning

Warning: .then() only accepts functions but was passed: [object Undefined], [object Undefined]    at Object.push../node_modules/plotly.js/src/lib/index.js.lib.syncOrAsync (http://localhost:3000/packs/js/vendors~._node_modules_plotly.js_src_c-9f52df4a5f1ee8c919dc.chunk.js:3256:38)    at relayout (http://localhost:3000/packs/js/vendors~._node_modules_plotly.js_src_c-9f52df4a5f1ee8c919dc.chunk.js:10431:22)    at Object.push../node_modules/plotly.js/src/registry.js.exports.call (http://localhost:3000/packs/js/vendors~._node_modules_pl-6439151412dfacf8a22d.chunk.js:246:42)    at http://localhost:3000/packs/js/vendors~._node_modules_plotly.js_src_c-9f52df4a5f1ee8c919dc.chunk.js:28740:16

Deleting the line should not have side effects:

plotly.js/src/lib/index.js

Line 459 in e27ca3c

.then(undefined, lib.promiseError);

So please change it to the following code an leave error handling to the caller that provided a promise.

lib.syncOrAsync = function(sequence, arg, finalStep) {
    var ret, fni;

    function continueAsync() {
        return lib.syncOrAsync(sequence, arg, finalStep);
    }

    while(sequence.length) {
        fni = sequence.splice(0, 1)[0];
        ret = fni(arg);

        if(ret && ret.then) {
            return ret.then(continueAsync);
        }
    }

    return finalStep && finalStep(arg);
};