Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing 3 Dash app parameters, should support for full parity with Python #69

Closed
TahiriNadia opened this issue Mar 27, 2019 · 2 comments
Closed

Missing 3 Dash app parameters, should support for full parity with Python #69

TahiriNadia opened this issue Mar 27, 2019 · 2 comments
Assignees
@rpkyle
Labels
enhancement

Comments

@TahiriNadia
Copy link
Contributor 

app.index_string = '''
<!DOCTYPE html>
<html>
    <head>
        {%metas%}
        <title>{%title%}</title>
        {%favicon%}
        {%css%}
    </head>
    <body>
        <div>My Custom header</div>
        {%app_entry%}
        <footer>
            {%config%}
            {%scripts%}
            {%renderer%}
        </footer>
        <div>My Custom footer</div>
    </body>
</html>
'''

I'm trying app$index_string but not found?
@TahiriNadia TahiriNadia self-assigned this Mar 27, 2019
@rpkyle
Copy link
Contributor

rpkyle commented Mar 28, 2019 •
edited
Loading

@TahiriNadia Good catch. I think we're missing the following parameters, which I should add for parity with Dash for Python.

We hadn't done it yet because it wasn't a task item for the initial release, but now's a good time to bolt down the API and round off the loose edges.

So, we're actually missing a few options here:

  • compress
  • meta_tags
  • index_string

I'll slide this onto the project board so we keep track of this issue.

@rpkyle rpkyle changed the title No index_string implemented in R Missing 3 Dash app parameters, should support for full parity with Python Mar 28, 2019
@rpkyle rpkyle assigned rpkyle and unassigned TahiriNadia Mar 28, 2019
@rpkyle
Copy link
Contributor

rpkyle commented May 24, 2020

The parameters required were added in #157, #168, and #142. Closing.

@rpkyle rpkyle closed this as completed May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rpkyle rpkyle

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rpkyle @TahiriNadia