-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Make all js dependencies as assets #868
Comments
@rpkyle @alexcjohnson in step2, if we compute all the bundle hash and dump then in a dict like
this can be used as extra test in CI, or local development env whenever we have a doubt, just compare the content with the hash |
Can we just use
|
this is like testing the but the hash output is more like a reference when we release a dash version, we can tell if the bundles we built or copied from npm_modules are changed by |
Is your feature request related to a problem? Please describe.
the
dash-renderer
repo includes both source code and binary assets/bundles for historical reasons. This is in general not good practices:Describe the solution you'd like
a similar solution as proposed in plotly/dash-core-components#597
the repo should only contain source code, from the clean env, we do the build from a python script:
npm i --ignore-scripts
package-lock.json
, copy the required bundles into dash_core_components, compute the content hash and dump all the fingerprint in a json file. this file can be included in the release as an alternative way than version to check the assets correctness.__init__.py
, so we have the single version of truth from npmnpm run build
at this point, we should be able to dev and test from
pip install -e .
apply the same procedure in circleci, and see how it applies for the release automation
Additional context
the script should work in both python2 and 3
The text was updated successfully, but these errors were encountered: