Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Make percy finalize only once #993

Closed
byronz opened this issue Nov 1, 2019 · 1 comment
Closed

[Feature Request] Make percy finalize only once #993

byronz opened this issue Nov 1, 2019 · 1 comment

Comments

@byronz
Copy link
Contributor

byronz commented Nov 1, 2019

we are currently limited by the Percy Python API in a way that its lifecycle is bound with a selenium webdriver. and there is no easy way to finalize that with a simple direct API call from Percy itself.

another problem we are having in dash repo is that due to the limitation of circleci workflow, a failure of test run will skip the proper percy finalize job.

Proposed solution:
if we can find out a way to properly finalize the percy runner with Python, then we can define a percy fixture with scope='session', and doing the finalize with the pytest lifecycle.

@byronz
Copy link
Contributor Author

byronz commented Nov 4, 2019

solved by plotly/dashR#138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant