Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit history when show_undo_redo=False #727

Open
alexcjohnson opened this issue May 21, 2019 · 1 comment
Open

Limit history when show_undo_redo=False #727

alexcjohnson opened this issue May 21, 2019 · 1 comment
Labels
feature something new P3 backlog performance something is slow

Comments

@alexcjohnson
Copy link
Collaborator

After #724 and plotly/dash-renderer#175, the state history is only relevant to revert, which is used for error recovery so only needs to hold one previous (good) state as described in plotly/dash-renderer#175 (comment). If we simplify the history when the undo/redo toolbar is hidden, we may see a significant performance boost for large and/or frequently-updated apps.

Possibly related: #699, #707

@nicolaskruchten
Copy link
Contributor

If undo/redo has a big perf hit it would be nice to add a parameter for "number of undo/redo steps" even when it's on. And then turning it off would default it to 1.

@gvwilson gvwilson self-assigned this Jul 17, 2024
@gvwilson gvwilson removed their assignment Aug 2, 2024
@gvwilson gvwilson added P3 backlog and removed dash-type-maintenance labels Aug 13, 2024
@gvwilson gvwilson changed the title [Performance] Limit history when show_undo_redo=False Limit history when show_undo_redo=False Aug 13, 2024
@gvwilson gvwilson added performance something is slow feature something new labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new P3 backlog performance something is slow
Projects
None yet
Development

No branches or pull requests

3 participants