Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation is incorrect: a barebones theme needs manifest.cfg #105

Open
tkimnguyen opened this issue Jun 3, 2016 · 1 comment
Open

Comments

@tkimnguyen
Copy link
Sponsor Member

Re: plone/Products.CMFPlone#1622 the documentation at http://docs.plone.org/external/plone.app.theming/docs/index.html#creating-a-new-theme says that uploading a ZIP containing just an index.html will work, because the rules.xml will get auto-generated. The theme does get created, however, without a manifest.cfg, the theme does not show in the @@theming-controlpanel.

The doc here should state that you need at least a minimal manifest.cfg containing

[theme]
title = My New Theme
@davilima6
Copy link
Member

davilima6 commented Jun 3, 2016

Actually documentation is right as we can confirm by looking at the changelog:

1.0b4 - 2011-05-24
Fix zip import to work correctly when no manifest is supplied. [elro]

We could improve docs by making that explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants