Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much pinnings in buildout.cfg? #301

Closed
idgserpro opened this issue Jun 22, 2018 · 3 comments
Closed

Too much pinnings in buildout.cfg? #301

idgserpro opened this issue Jun 22, 2018 · 3 comments

Comments

@idgserpro
Copy link

idgserpro commented Jun 22, 2018

I've just created a package for a legacy system with Plone 4.3.9 with this package (I'm using plonecli 0.2.0 and bobtemplates.plone 3.3.0.)

Checking the generated buildout.cfg, I've seen that we have at least 40 packages pins. Don't you think this is too much? Since they're said to be # development dependencies (tools and pre commit hook) **, don't** we have a development.cfg effort like http://dist.plone.org/release/4.3-latest/versions.cfg for example? @esteele what do you think?

@jensens
Copy link
Member

jensens commented Aug 7, 2018

IMO it overrides too many packages. At least for Plone 5.1 this is not needed. It also adds headache when upgrading to a new Plone version (even if its just a bugfix release). The pins should be checked very carefully and there should be a reason noted as comment or as an plone.versioncheck compatible section entry.

@MrTango
Copy link
Contributor

MrTango commented Oct 18, 2018

Help is very welcome ;)

@MrTango MrTango added this to the 4.0 milestone Mar 10, 2019
@MrTango MrTango closed this as completed Mar 11, 2019
@idgserpro
Copy link
Author

@MrTango I've come to the conclusion that the way to go is pinning upstream. For example:

plone/Products.CMFPlone#2867

When added upstream (and deciding what to do in plone/plonecli#52) I think we can remove all the pinnings for 4.3.

So, I think this issue can be reopened.

Help is very welcome ;)

I know. Since we can't sign the contributor's agreement for core plone packages, the help we can give is only opening issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants