Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghostl library not installed via PlatformIO #307

Open
CraigBurden opened this issue Jan 11, 2024 · 8 comments · May be fixed by #308
Open

Ghostl library not installed via PlatformIO #307

CraigBurden opened this issue Jan 11, 2024 · 8 comments · May be fixed by #308

Comments

@CraigBurden
Copy link

Hi there,

When adding this library to a PIO project using plerup/EspSoftwareSerial@^8.2.0 the build fails as the ghostl library has not been installed and the circular_queue.h file is not found.

This can easily be fixed by adding https://github.com/dok-net/ghostl to lib_deps, but should not be required if the dependency is setup correctly

@sartyx
Copy link

sartyx commented Jan 13, 2024

doesn't really work?

Library Manager: Installing dok-net/ghostl @ ^1.0.0
Library Manager: Warning! Could not install `{'owner': 'dok-net', 'name': 'ghostl', 'version': '^1.0.0'}` dependency for the`EspSoftwareSerial` package

@dok-net
Copy link
Collaborator

dok-net commented Jan 14, 2024

@sartyx @CraigBurden @Sjorsa I've spoken to the original EspSoftwareSerial maintainer, from whom I've taken over. He wasn't the one who registered EspSoftwareSerial with platform.io either - but isn't able to find out who it was and who's potentially behind registering new releases.
And no, it's not necessary for the registrant to be the same person as the development lead. This is open source. If nobody takes any perceived "risk" to have a little effort, nobody is entitled to complain, either :-)
If you have an platformio account or are willing to create one, and if you can think you can show due dilligence in submitting, reviewing the result and perhaps updating for new releases in the forseeable near future, please go ahead and publish ghostl. It is OK by me!!! I'm just not going to do it myself, there's nothing in that for me except the hassle.

@popos123
Copy link

popos123 commented Feb 24, 2024

Hi, after installing git basch for windows, I was try to add lib_deps =
maxgerhardt/ghostl@^1.0.0
and
https://github.com/dok-net/ghostl/archive/refs/tags/1.0.0.zip
and
https://github.com/dok-net/ghostl/

and still doesn't work, ive got an error:

Resolving pico32 dependencies...
Library Manager: Installing dok-net/ghostl @ ^1.0.0
UnknownPackageError: Could not find the package with 'dok-net/ghostl @ ^1.0.0' requirements for your system 'windows_amd64'

EDIT: on version 1.0.1 still the same ...
EDIT2: for now, the forked version is working great: https://github.com/jmceleney/espsoftwareserial

@verilog-indeed
Copy link

doesn't really work?

Library Manager: Installing dok-net/ghostl @ ^1.0.0
Library Manager: Warning! Could not install `{'owner': 'dok-net', 'name': 'ghostl', 'version': '^1.0.0'}` dependency for the`EspSoftwareSerial` package

Just had the same issue, solved it by cloning the https://github.com/dok-net/ghostl repo into my libs folder, make sure that dok-net/ghostl is NOT part of lib_deps.

Bascy added a commit to Bascy/espsoftwareserial that referenced this issue Mar 12, 2024
@Bascy
Copy link

Bascy commented Mar 12, 2024

Solved it bij splitting name and version in library.json (See pull request)

"dependencies": {
        "name": "ghostl",
        "version": "maxgerhardt/ghostl@^1.0.0"
    }

You can also specify a direct url into the github repo in stead of <owner>/<repo> construction

@popos123
Copy link

so anyone cane make a new release e.g. 8.3.0 with two critical fixes from this #307 and #311 and optionally from #310?
really please, this library is almost perfect :(

@sartyx
Copy link

sartyx commented Mar 28, 2024

you can make your own fork/version on the upper right corner with the fixes

@dok-net
Copy link
Collaborator

dok-net commented Apr 21, 2024

Fixed by publishing the ghostl library to PIO under my own account now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants