feat: add environment suffix to github artifact #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WEB-667 Investigate GitHub upload issues that are causing deployment failures.
Timebox investigation |
tkloht
changed the title
macko911
approved these changes
Sep 14, 2023
just for reference, we definitely don't use the github artifact for upload to s3 - that happens here spa-tools/reusable-workflows/deploy.yml Line 110 in ec67123 i'm not aware of anything else we use it for |
currently we're only using the tree_hash as name of our artifact, but tree_hash is the same across all environments. So we're overwriting existing artifacts and only have a single one for production in the end. After this change we should have an artifact per environment. I'm hopeful that this will also fix the errors we're seeing since introducing the product-dev environment, my assumption is that github locks the artifact for a short time during upload and when the stars align product-dev and staging upload at the same time, creating this error.
tkloht
force-pushed
the
feature/web-667-investigate-github-upload-issues-that-are-causing-deployment
branch
from
ec67123 to
1aee4ef
Compare
jogilvyt
approved these changes
Sep 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently we're only using the tree_hash as name of our artifact, but tree_hash is the same across all environments. So we're overwriting existing artifacts and only have a single one for production in the end.
After this change we should have an artifact per environment.
I'm hopeful that this will also fix the errors we're seeing since introducing the product-dev environment, my assumption is that github locks the artifact for a short time during upload and when the stars align product-dev and staging upload at the same time, creating this error.
to my best knowledge we're not using these artifacts programatically & we only upload the artifact for reference, so this should be safe to rename.