Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement if there's only 1 reply page, don't create reply page cids, only add "best" sort and sort the other types client side #48

Open
estebanabaroa opened this issue Sep 13, 2024 · 0 comments

Comments

@estebanabaroa
Copy link
Member

if all replies fit in 1 page, dont create reply page cids to reduce the amount of cids to announce

instead store all the replies only on post.replies.pages.best at the protocol level

and clientside, you can create all the other pages and add them to the Comment instance

so you could create:

post.replies.pages.best
post.replies.pages.new
post.replies.pages.newflat
post.replies.pages.old
post.replies.pages.oldFlat

if pageCids exist, dont do this, because it's not possible to create page1 of new and old with only the partial best replies, the first page wouldn't be accurate, instead you should create:

post.replies.pages.best
post.replies.pagesCids.new
post.replies.pagesCids.newflat
post.replies.pagesCids.old
post.replies.pagesCids.oldFlat

no need to create post.replies.pagesCids.best because the first page with the cid of page 2 is already included in post.replies.pages.best so it would just waste a cid to announce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant