Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expect-expect - false warning #149

Closed
EvgenyOrekhov opened this issue Jun 26, 2023 · 3 comments
Closed

expect-expect - false warning #149

EvgenyOrekhov opened this issue Jun 26, 2023 · 3 comments

Comments

@EvgenyOrekhov
Copy link

This gives false expect-expect warning

test('2 tabs', async ({ context, page }) => {
  await test.step('first tab', async () => { // <-- Test has no assertions (false warning)
    const frame = getFrame(page);
    await expect(frame.getByText('Hello')).toBeVisible();
  });

  await test.step('second tab', async () => {
    const frame2 = await openNewTabAndGetFrame(context);
    await expect(frame2.getByText('Hello')).toBeVisible();
  });
});
@mskelton
Copy link
Member

Thanks for reporting, I've pushed a fix for this.

@AntonNiklasson
Copy link

Any chance we could get a release out for this @mskelton? 👏

@github-actions
Copy link

🎉 This issue has been resolved in version 0.15.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants