From cb7b33a676099a8c96f656560ddeae3e2db9989c Mon Sep 17 00:00:00 2001 From: Paulo Date: Wed, 21 Sep 2022 16:25:03 +0100 Subject: [PATCH 1/2] Fix incorrect method comments in vec2 - Change references from addition to subtraction in vector subtraction methods; sub, sub2 --- src/math/vec2.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/math/vec2.js b/src/math/vec2.js index 265e3dabf96..bc4858fd3c2 100644 --- a/src/math/vec2.js +++ b/src/math/vec2.js @@ -480,7 +480,7 @@ class Vec2 { /** * Subtracts a 2-dimensional vector from another in place. * - * @param {Vec2} rhs - The vector to add to the specified vector. + * @param {Vec2} rhs - The vector to subtract from the specified vector. * @returns {Vec2} Self for chaining. * @example * var a = new pc.Vec2(10, 10); @@ -501,8 +501,8 @@ class Vec2 { /** * Subtracts two 2-dimensional vectors from one another and returns the result. * - * @param {Vec2} lhs - The first vector operand for the addition. - * @param {Vec2} rhs - The second vector operand for the addition. + * @param {Vec2} lhs - The first vector operand for the subtraction. + * @param {Vec2} rhs - The second vector operand for the subtraction. * @returns {Vec2} Self for chaining. * @example * var a = new pc.Vec2(10, 10); From 3fb9d5f9a0a05b4b95227f4279523cda36e09dec Mon Sep 17 00:00:00 2001 From: Paulo Date: Wed, 21 Sep 2022 16:25:18 +0100 Subject: [PATCH 2/2] Fix incorrect method comments in vec3 - Change references from addition to subtraction in vector subtraction methods; sub, sub2 --- src/math/vec3.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/math/vec3.js b/src/math/vec3.js index d59c7db9962..df6707ee650 100644 --- a/src/math/vec3.js +++ b/src/math/vec3.js @@ -543,7 +543,7 @@ class Vec3 { /** * Subtracts a 3-dimensional vector from another in place. * - * @param {Vec3} rhs - The vector to add to the specified vector. + * @param {Vec3} rhs - The vector to subtract from the specified vector. * @returns {Vec3} Self for chaining. * @example * var a = new pc.Vec3(10, 10, 10); @@ -565,8 +565,8 @@ class Vec3 { /** * Subtracts two 3-dimensional vectors from one another and returns the result. * - * @param {Vec3} lhs - The first vector operand for the addition. - * @param {Vec3} rhs - The second vector operand for the addition. + * @param {Vec3} lhs - The first vector operand for the subtraction. + * @param {Vec3} rhs - The second vector operand for the subtraction. * @returns {Vec3} Self for chaining. * @example * var a = new pc.Vec3(10, 10, 10);