Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bloom PostProcessing example, error thrown when light is added #5844

Closed
MAG-AdrianMeredith opened this issue Nov 23, 2023 · 2 comments · Fixed by #5845
Closed

Bloom PostProcessing example, error thrown when light is added #5844

MAG-AdrianMeredith opened this issue Nov 23, 2023 · 2 comments · Fixed by #5845
Assignees
Labels
area: graphics Graphics related issue feature request

Comments

@MAG-AdrianMeredith
Copy link
Contributor

The new "renderpass" post processing example throws an exception when a shadow casting light is added.

Steps to Reproduce

  1. go to https://playcanvas.github.io/#/graphics/postprocessing
  2. add boardEntity.addComponent('light', {type:'directional', castShadows: true}); to line 88
    3.playcanvas.js:29104 Uncaught TypeError: Cannot read properties of null (reading 'width') is found

It appears the shadowCaster camera has no render target...
image

@mvaligursky
Copy link
Contributor

Yep, this is in preview and many things are not done. Specially, directional shadow passes and depth/color passes are not in a form to be easily added to the camera passes, and so those don't work. This should be ready for the next minor engine release (working on some of it now)

@MAG-AdrianMeredith
Copy link
Contributor Author

No worries, its looking great just thought I'd be good to get it logged in case you weren't aware

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue feature request
Projects
None yet
2 participants