Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main branch engine generates Shader Error in the Editor #4659

Closed
weilichuang opened this issue Sep 23, 2022 · 1 comment · Fixed by #4670
Closed

Main branch engine generates Shader Error in the Editor #4659

weilichuang opened this issue Sep 23, 2022 · 1 comment · Fixed by #4670
Assignees
@slimbuck @GSterbrant
Labels
area: graphics Graphics related issue bug

Comments

@weilichuang
Copy link
Contributor

Use the git version playcanvas.

Project:https://playcanvas.com/editor/scene/1530394

shader_err
@mvaligursky mvaligursky added bug area: graphics Graphics related issue labels Sep 23, 2022
@slimbuck
Copy link
Member

Thanks for raising this one @weilichuang!

Recent change broke this https://github.com/playcanvas/engine/pull/4636/files#diff-0b850a404fa1dc3f4ed648bac2c701107284d10aee6ef6c2b6dd1f144d7ba409R14

(as well as the diffuseDetail chunk).

@mvaligursky mvaligursky changed the title Shader Error Main branch engine generates Shader Error in the Editor Sep 26, 2022
@slimbuck slimbuck mentioned this issue Sep 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slimbuck slimbuck

@GSterbrant GSterbrant

Labels
area: graphics Graphics related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix chunk decode calls slimbuck/engine
4 participants
@weilichuang @slimbuck @mvaligursky @GSterbrant