Typing in the year in the custom range date picker no longer works

[metmarkosaric]

I've tried this on my own and can replicate the issue.

(reported via twitter dm)

[ukutaht]

This regression was introduced in #735. The site switching keybindings are interfering with entering numbers into the datepicker.

Fixing it would require some sort of horrible global state so the site switcher can ignore the keybind when datepicker is open. @Vigasaurus any other ideas?

[Vigasaurus]

Assuming the datepicker uses a basic input element, we could just have the keydown handler check the event target for if it's of input type and break out. Or honestly, the datepicker is what handles both the keybindings and keeps the flatpickr state, so it could be as simple as checking the open state in the keydown, similar to the code below. nevermind, idk why I thought it was the datepicker keybinds interfering

Something like:

if (['INPUT', 'TEXTAREA'].includes(e.target.tagName)) return;

...rest
e.preventDefault();

[ukutaht]

Fantastic @Vigasaurus that's a much better idea than introducing global state.