Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic support for KL430 Light Strip #34

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Conversation

plasticrake
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #34 (7e1db57) into master (73d1151) will increase coverage by 0.65%.
The diff coverage is 63.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   55.95%   56.61%   +0.65%     
==========================================
  Files          31       35       +4     
  Lines         772      839      +67     
  Branches       30       30              
==========================================
+ Hits          432      475      +43     
- Misses        335      360      +25     
+ Partials        5        4       -1     
Impacted Files Coverage Δ
src/devices/base.js 65.51% <0.00%> (-1.15%) ⬇️
src/utils.js 67.46% <42.85%> (-2.46%) ⬇️
src/devices/kl.js 55.31% <55.31%> (ø)
src/device.ts 63.63% <100.00%> (+3.17%) ⬆️
src/devices/data/kl.js 100.00% <100.00%> (ø)
src/devices/data/kl430.js 100.00% <100.00%> (ø)
src/devices/hs.js 17.51% <100.00%> (+0.12%) ⬆️
src/devices/kl430.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d1151...7e1db57. Read the comment docs.

@coveralls
Copy link

coveralls commented Feb 1, 2022

Pull Request Test Coverage Report for Build 1781135784

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 47 of 74 (63.51%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 52.464%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/devices/base.js 0 2 0.0%
src/utils.js 3 7 42.86%
src/devices/kl.js 26 47 55.32%
Totals Coverage Status
Change from base Build 1770580160: 0.8%
Covered Lines: 473
Relevant Lines: 827

💛 - Coveralls

@plasticrake plasticrake merged commit 385a5be into master Feb 1, 2022
@plasticrake plasticrake deleted the feat/kl430 branch February 1, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants