Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you take a PR to change build to CMake? #170

Closed
rconde01 opened this issue Oct 15, 2020 · 4 comments
Closed

Would you take a PR to change build to CMake? #170

rconde01 opened this issue Oct 15, 2020 · 4 comments

Comments

@rconde01
Copy link

As a first step to building on windows it would be good to change the build to CMake. Would you take that PR?

@emeryberger
Copy link
Member

Sure, as long as it fully replaces the functionality of the existing Makefile!

@klimkin
Copy link
Contributor

klimkin commented Oct 28, 2020

This could be a good starting point: conan-io/conan-center-index#3282

  • The CMakeLists.txt builds everything except benchmarks.
  • Will need to clarify lookup for libelfin libraries, if building outside of Conan environment

Another option is to use Conan+CMake, this would simplify dependency management from libelfin.

@klimkin
Copy link
Contributor

klimkin commented Jan 8, 2021

#178

@klimkin
Copy link
Contributor

klimkin commented Mar 23, 2021

This can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants