-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C4_Dynamic no longer numbers all relationships #320
Comments
Hi @hansensmythe, |
Using this diagram: @startuml
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Dynamic.puml
Boundary(a, 'Direction ""Rel""'){
Rel_Down( Rel_Down, X, "")
Rel_Up( Rel_Up, X, "")
Rel_Right(Rel_Right, X, "")
Rel_Left( Rel_Left, X, "")
}
Boundary(b, 'Direction ""Rel"" Shorthand'){
Rel_D(Rel_D, Y, "")
Rel_U(Rel_U, Y, "")
Rel_R(Rel_R, Y, "")
Rel_L(Rel_L, Y, "")
}
Boundary(c, 'Plain ""Rel"" and ""BiRel""'){
Rel(Rel, Z, "")
BiRel(Birel, Z, "")
}
@enduml It can be seen that Doing a regression check, none of the versions show a number for
|
Hi @hansensmythe, I have a bugfix in my extended branch, can you please test it with your diagrams? !include https://raw.githubusercontent.com/kirchsth/C4-PlantUML/extended/C4_Dynamic.puml Thank you and best regards |
@Potherca PS,; BiRel_* was never supported |
@hansensmythe: v.2.8.0 with fix released |
Until recently (mid-July?) diagrams could get relationships automatically numbered in order of use by using
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Dynamic.puml
This was useful for diagramming auth chains, for example, where each relationship relies on a change of state from a previous relationship, e.g.
1: Get the object from Container 1
2: Send the object to Container 2 for modification
3: Send the object to Container 3 for further modification
However, the same diagrams now fail to number some relationships - it appears that 'Rel_L', 'Rel_R', 'Rel_U', and 'Rel_D' relationships get numbered, but plain 'Rel' relationships do not.
The text was updated successfully, but these errors were encountered: