Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust thickness of element border #315

Closed
qtzar opened this issue Jul 11, 2023 · 6 comments · Fixed by #319
Closed

Adjust thickness of element border #315

qtzar opened this issue Jul 11, 2023 · 6 comments · Fixed by #319
Assignees
Milestone

Comments

@qtzar
Copy link

qtzar commented Jul 11, 2023

I would like to be able to adjust the thickness of the element border on diagrams.

@kirchsth
Copy link
Member

Hi @qtzar,

I couldn't test all shapes, but I could try to support it like the Rel() implementation via tags. (details see #254)

@startuml
!include <C4/C4_Component.puml>

' SHOW_PERSON_PORTRAIT() ' not working??
' skinparam actorBorderThickness 15.0  ' not working??
' skinparam actorBorderStyle 15.0  ' not working??

SHOW_PERSON_OUTLINE()
skinparam personBorderThickness 15.0
skinparam personBorderStyle dashed

skinparam rectangleBorderThickness 5.0
skinparam rectangleBorderStyle dashed

Person(P,"Person")
Component(C,"Component","techn")


AddRelTag(special, $textColor="$ARROW_FONT_COLOR", $lineColor="$ARROW_COLOR", $lineStyle=DashedLine(), $lineThickness=5)
Rel(P,C,"uses",$tags=special)

SHOW_LEGEND()
@enduml

BR Helmut

@kirchsth
Copy link
Member

If possible AddBoundaryTag() and UpdateBoundaryStyle() should be extended too

@kirchsth kirchsth added this to the v2.8.0 milestone Jul 11, 2023
@kirchsth
Copy link
Member

Atm border thickness cannot be changed per component. Opened a question in forum

kirchsth added a commit to kirchsth/C4-PlantUML that referenced this issue Aug 13, 2023
kirchsth added a commit to kirchsth/C4-PlantUML that referenced this issue Aug 13, 2023
@kirchsth
Copy link
Member

Hi @qtzar,

I have a first version: the border style and thickness of all elements and boundaries can be defined via tags.
Can you please check it via in my extended branch.
Does it match your expectations?

Thank you and best regards
Helmut

PS.: I extended all Add...Tag() with (..., $borderStyle="", $borderThickness="") too, but I forgot the update in the readme

@qtzar
Copy link
Author

qtzar commented Aug 14, 2023

Just got a chance to test this, grabbed one of my puml files, changed the imports to point to your extended branch and added the borderStyle and borderThickness declarations to a few of the AddElementTags in the puml and generated an diagram.

It looked great and exactly what I was looking for. Plan for using this is to be able to set border colors and styles for containers that are being change in future state diagrams.

@kirchsth kirchsth self-assigned this Aug 15, 2023
kirchsth added a commit to kirchsth/C4-PlantUML that referenced this issue Aug 15, 2023
@kirchsth kirchsth linked a pull request Aug 15, 2023 that will close this issue
kirchsth added a commit that referenced this issue Sep 2, 2023
kirchsth added a commit that referenced this issue Sep 2, 2023
@kirchsth
Copy link
Member

@qtzar: v.2.8.0 with border styles released

@kirchsth kirchsth modified the milestones: v2.8.0, v2.10.0 May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants